67b70f024568 — Johannes Hofmann default tip 3 years ago
fix build with --disable-ssl

submitted-by: John DiMarco <jdd@cs.toronto.edu>
f60d55c02567 — Johannes Hofmann 5 years ago
add --disable-xembed configure option

Add option to disable XEmbed support.
This can be useful to avoid compilation issues on non-X11 systems.
0cb3ef492f54 — Johannes Hofmann 6 years ago
merge
887186a30605 — Johannes Hofmann 6 years ago
fix compile time X11 detection with fltk-1.3.4+

This should fix "-x <window id>" when dillo is compiled with fltk-1.3.4.

Reported-by: Arthur Huillet
51dcebebbaa6 — Jorge Arellano Cid 7 years ago
Fix minor indentation typo.
9862ad8cc8f8 — Jorge Arellano Cid 7 years ago
Merged commit #4653 (float clearance).

Test case:

<body>
    <div id="a">
        <div id="b" style="float:left">main</div>
    </div>
    <div id="c" style="clear:left"></div>
    <div id="d">footer</div>
</body>


Note: passes all the tests at
      http://www.dillo.org/test/4648/test-suite.v1.txt
6bf4db806b57 — Jorge Arellano Cid 7 years ago
Revert commit #4651

Introduces regressions:

.-------.--------.------.-----------.-----------------------.-----.-----.
|       |   BTG  | test | pravda.ru |         4ta.html      | VT  | PV  |
|       | render | t.*  | #1  | #2  | Girl | footb. | horos.|     |     |
|-------|--------|------|-----------|-----------------------|-----|-----|
|d4594  |   ok   |  ok  | x a | x b |  x c |  ok    |  x d  | x i | x k |
'-----------------------------------------------------------------------'

Note: patch #4594 is the same as patch #4651.
(we use d4594 to avoid side effects from other patches).

Check this testsuite [1] for more details.

[1] http://www.dillo.org/test/4648/test-suite.v1.txt
14733bcd4cfe — Jorge Arellano Cid 7 years ago
Revert commit #4652

Introduces regressions:

.-------.--------.------.-----------.-----------------------.-----.-----.
|       |   BTG  | test | pravda.ru |         4ta.html      | VT  | PV  |
|       | render | t.*  | #1  | #2  | Girl | footb. | horos.|     |     |
|-------|--------|------|-----------|-----------------------|-----|-----|
|d4652  |   ok   |  ok  | x a | x ic|  ok  |  x l   |  x d  | x n | ok  |
'-----------------------------------------------------------------------'

Check this testsuite [1] for more details.

[1] http://www.dillo.org/test/4648/test-suite.v1.txt
31205ec799ab — Jorge Arellano Cid 7 years ago
Revert commit #4653 (on hold)

This patch is "on hold", as it depends on reverted code,
and at least would need a non-automatic merge.
f4bea23749df — Sebastian Geerken 7 years ago
Remove obsolete method.
be9bdfd3f848 — Sebastian Geerken 7 years ago
Fix update problem related to CSS 'clear'.
72c9d5f9372b — Sebastian Geerken 7 years ago
Fix Layout::viewportSizeChanged.
072f0c158c66 — Sebastian Geerken 7 years ago
Reverse commit 4647:8c6b1b79d329.
da460fb294e3 — Sebastian Geerken 7 years ago
Comment on Jorge's commit.
ad7da0d26dad — Sebastian Geerken 7 years ago
RTFL.
bbd0bdde0e01 — Jorge Arellano Cid 7 years ago
fix Layout::viewportSizeChanged.

When changing viewport size, sometimes the resize wasn't propagated properly.

e.g. pravda #2 in the results below.


Here follows the test suite and its results:
--------------------------------------------


Legend: d4646 = dillo version #4646 in Mercurial repository.
        x a = Test failed, with code a = Problems 1, 9 and 3.
Custom test pages at: http://www.dillo.org/test/4648/


                              Results Table
.-------.--------.------.-----------.-----------------------.-----.-----.
|       |   BTG  | test | pravda.ru |         4ta.html      | VT  | PV  |
|       | render | t.*  | #1  | #2  | Girl | footb. | horos.|     |     |
|-------|--------|------|-----------|-----------------------|-----|-----|
|d4648  |   ok   |  ok  | ok  | ok  |  ok  |  ok    |  ok   | ok  | ok  |
|d4647  |   ok   |  ok  | ok  | x g |  ok  |  ok    |  ok   | ok  | ok  |
|d4646  |   ok   |  ok  | x a | x l |  ok  |  x j   |  x d  | x n | ok  |
|d4645  |   ok   |  ok  | x m | x l |  ok  |  x j   |  x d  | ok  | ok  |
|d4644  |   ok   |  ok  | x a | x b |  ok  |  x j   |  x d  | ok  | x k |
|incr   |   ok   |  ok  | x a | x b |  x c |  ok    |  x d  | ok  | x k |
|d4587t2|~  x f  |  ok  | ok  | ok  |  ok  |  ok    |  ok   | x i |     |
|d4587+ |   ok   |  ok  | ok  | ok  |  ok  |  ok    |  ok   | x i | x k |
|d4587  |   ok   |  x e | ok  | ok  |  ok  |  ok    |  ok   | x i | x k |
|d4584  |   ok   |  x h | ok  | ok  |  ok  |  ok    |  ok   | x i | x k |
 -----------------------------------------------------------------------|
|ok7    |   ok   |  ok  | ok  | x g |  ok  |  ok    |  ok   |     |     |
|tmp8   |   ok   |  x e |     |     |      |        |       |     |     |
|tmp9   |   ok   |  ok  |     |     |      |        |       |     |     |
|tmp9.1 |   ok   |  ok  | ok  | x g |  ok  |  ok    |  ok   |     |     |
'-----------------------------------'-----------------------------'-----'
 ___________________________________________________________
/   a   |   b   | c |  d  | e | f | g  | h  | i  |  j  | k  \  incr = d4594
| 1 9 3 | 1 9 4 | 9 | 1 5 | 6 | 7 | 4  | 12 | 13 | 8 9 | 10 | 47 = prune patch
'------------------------------------------------------'----' 45 = idle patch
| l: 13 | m: 4 2| n: 5 9  |                                   46 = words patch
                                                              48 = viewportchg
Problems:
1: overwrites text with images.
2: crops images (aspect ratio).
3: different layout.
4: overwrites text with float.
5: overwrites text with text.
6: CPU HOG with: t2.n, t2.n.sm
7: Missing page sections (sometimes works for the same page).
8: Small images cut in two sometimes ("ESP", "CRO", ...)
9: Wrong aspect ratio for images (text line height)
10: Page drawn with offset (but browser thinks other section is on screen).
11: CPU HOG.
12: CPU HOG with: t1, t1n, t2.n, t2.n.sm, t3.
13: overwrites text and images with text and images.

Goods:
*: works for the whole t.* suite.

Testing (all with background images disabled):

BTG:
 1.- Bck/Fwd several times (first at normal then maximized).
 2.- resize from max to normal several times.

pravda #1:
 1. Load [1] at normal size, wait most images to load, check images and check
    them not to overlap text, go Bck/Fwd, check again.
 2. Maximize window, check images don't overlap text, check the page layout
    to have three main columns (the upper part). Go Bck/Fwd, check again.

pravda #2:
 1. Load [1] at normal size, wait most images to load, then load [2],
    press page down, check the "print version" float doesn't overlap text,
    or images (they may stack), check the two images inside it have the
    same size and ratio, maximize, return to normal, check the float again.

4ta:
1. Run dillo, disable images, load 4ta.html, click Girl img, go Bck/Fwd,
   check img, exit dillo.
2. Run dillo, disable images, load 4ta.html, click football img, go Bck/Fwd,
   check img, exit dillo.
3. Run dillo, disable images, load 4ta.html, click tauro img, check horoscope
   text, go Bck/Fwd, check h. text, click aries img, check h. text, go Bck/Fwd,
   check h. text, exit dillo.
4. Run dillo, disable images, load 4ta.html, click football img, go Bck/Fwd,
   click dep.png img, check images, go Bck/Fwd, check images.

VT:
 1. Load [3] at normal size, wait for most images to load, go Bck/Fwd, check
   images and text not to override each other.

PV:
 1. Load [5] at normal size, wait for most images to load, search for "re-re"
    with Find Text, press page down (you'll see an image), go Bck/Fwd, check
    the image is there. If not, you can place the cursor where the image was,
    if you get a hand cursor, Dillo thinks it is there. Wait for the tooltip
    and drag it a bit downwards to the right, Dillo will repaint from the image
    data.

[1] http://tinyurl.com/j2yavxk
[2] http://tinyurl.com/gqso9eu
[3] http://tinyurl.com/msyl7x
[4] http://tinyurl.com/grd6yg4
[5] http://tinyurl.com/huvf6pn
8c6b1b79d329 — Jorge Arellano Cid 7 years ago
Change OOFFloatsMgr::markSizeChange()

We change to a graph coverage model, with pruning.
3bfefb5042e9 — Jorge Arellano Cid 7 years ago
Optimize Textblock::updateReference.

This helps to avoid unnecessary resize calls.
ab70f9ce4353 — Jorge Arellano Cid 7 years ago
Fix Layout::resizeIdle()

This was three year old bug, that went undiscovered (hg#2863).
The patch is simpler than it looks, it's just a while cycle enclosing
the body, indentation makes it look large.

How to reproduce:

 1. Load [5] at normal size, wait for most images to load, search for "re-re"
    with Find Text, press page down (you'll see an image), go Bck/Fwd, check
    the image is there. If not, you can place the cursor where the image was,
    if you get a hand cursor, Dillo thinks it is there. Wait for the tooltip
    and drag it a bit downwards to the right, Dillo will repaint from the image
    data.

[5] http://tinyurl.com/huvf6pn
46080df49751 — Jorge Arellano Cid 7 years ago
Bug meter message.
Next