e6c26c8ba4ea — Robin Stumm 6 years ago 
tui: improve readability of bindings::editor::parse_over(), remove hyper-sensitive comment
patch browse 
1 files changed, 6 insertions(+), 8 deletions(-)

M cursive/src/bindings/editor.rs

M cursive/src/bindings/editor.rs +6 -8
@@ 25,9 25,8 @@ use {
 pub fn parse_over(bindings: &Arr, props: &Properties) -> Result<SequenceTrie<Event, Cmd>, Either<OverError, ()>> {
     use either::Either::*;
 
-    // XXX undefined overflow
-    let page_up   = || props.view_height.map(|h| -(*h as isize));
-    let page_down = || props.view_height.map(|h|   *h as isize);
+    let page_up   = props.view_height.map(|h| -(*h as isize));
+    let page_down = props.view_height.map(|h|   *h as isize );
 
     let mut trie = SequenceTrie::new();
 

          
@@ 62,10 61,10 @@ pub fn parse_over(bindings: &Arr, props:
                 "Up-select"        => Cmd::Cur(CursorCmd::Vertical(true,  Signal::constant(-1))),
                 "Down"             => Cmd::Cur(CursorCmd::Vertical(false, Signal::constant( 1))),
                 "Down-select"      => Cmd::Cur(CursorCmd::Vertical(true,  Signal::constant( 1))),
-                "PageUp"           => Cmd::Cur(CursorCmd::Vertical(false, page_up  ())),
-                "PageUp-select"    => Cmd::Cur(CursorCmd::Vertical(true,  page_up  ())),
-                "PageDown"         => Cmd::Cur(CursorCmd::Vertical(false, page_down())),
-                "PageDown-select"  => Cmd::Cur(CursorCmd::Vertical(true,  page_down())),
+                "PageUp"           => Cmd::Cur(CursorCmd::Vertical(false, page_up.clone())),
+                "PageUp-select"    => Cmd::Cur(CursorCmd::Vertical(true,  page_up.clone())),
+                "PageDown"         => Cmd::Cur(CursorCmd::Vertical(false, page_down.clone())),
+                "PageDown-select"  => Cmd::Cur(CursorCmd::Vertical(true,  page_down.clone())),
                 "LineHome"         => Cmd::Cur(CursorCmd::LineHome(false, false)),
                 "LineHome-select"  => Cmd::Cur(CursorCmd::LineHome(true,  false)),
                 "LineEnd"          => Cmd::Cur(CursorCmd::LineEnd (false)),

          
@@ 89,7 88,6 @@ pub fn parse_over(bindings: &Arr, props:
 }
 
 pub fn defaults(props: &Properties) -> SequenceTrie<Event, Cmd> {
-    // XXX undefined overflow
     let page_up   = props.view_height.map(|h| -(*h as isize));
     let page_down = props.view_height.map(|h|   *h as isize );